Skip to content

Conversation

@TudorBalus
Copy link

Add two new parameters to the script:

  • -l, --lowestLimit: set what percentage is the lowest limit for printing a symbol.
  • -m, --maxItems: how many items in total should the script print.

Reasoning for the first would be that without it, the script prints hundreds of lines of symbols and it's hard to keep track of what feature(s) are the most impactful on ROM/ RAM. So by setting the lowestLimit to 1, the output gets trimmed down to the essential symbols that have an impact.
Reasoning for the second would be that it gives the user the chance to select how many symbols to be printed (can be used together with lowestLimit or standalone).

When they're not set, both parameters are given the default value (0), which makes the script behave as it normally would without them. -> the user may use them if he wants or not use them/ ignore them/ be completely unaware of them and everything works as before.

Recommended usage:
Add to Kconfig:
config REPORT_LOWEST_LIMIT
int "Minimum percentage to show in the report (0-100)"
default 0
range 0 100
help
Only show symbols that use at least this percentage of total ROM.
Set to 0 to show all symbols. Leaving it on default (0), includes everything.

config REPORT_MAX_ITEMS
int "Maximum number of symbols to show in the report"
default 0
help
Only shows as many symbols as defined by this option.
Leaving it on default (0), includes everything.

Add to prj.conf or board.conf:
CONFIG_REPORT_LOWEST_LIMIT=1
CONFIG_REPORT_MAX_ITEMS=10

Signed-off-by: TudorBalus [email protected]

 Add two new parameters to the script:
 - -l, --lowestLimit: set what percentage is the lowest limit for printing a symbol.
 - -m, --maxItems: how many items in total should the script print.

 Reasoning for the first would be that without it, the script prints hundreds of lines of symbols and it's hard to keep track of what feature(s) are the most impactful on ROM/ RAM. So by setting the lowestLimit to 1, the output gets trimmed down to the essential symbols that have an impact.
 Reasoning for the second would be that it gives the user the chance to select how many symbols to be printed (can be used together with lowestLimit or standalone).

 When they're not set, both parameters are given the default value (0), which makes the script behave as it normally would without them. -> the user may use them if he wants or not use them/ ignore them/ be completely unaware of them and everything works as before.

 Recommended usage:
 Add to Kconfig:
 config REPORT_LOWEST_LIMIT
     int "Minimum percentage to show in the report (0-100)"
     default 0
     range 0 100
     help
       Only show symbols that use at least this percentage of total ROM.
       Set to 0 to show all symbols. Leaving it on default (0), includes everything.

 config REPORT_MAX_ITEMS
     int "Maximum number of symbols to show in the report"
     default 0
     help
       Only shows as many symbols as defined by this option.
       Leaving it on default (0), includes everything.

 Add to prj.conf or board.conf:
 CONFIG_REPORT_LOWEST_LIMIT=1
 CONFIG_REPORT_MAX_ITEMS=10

 Signed-off-by: TudorBalus <[email protected]>
@NordicBuilder
Copy link
Contributor

none

Note: This comment is automatically posted and updated by the Contribs GitHub Action.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants